-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Concurrency] Updates after second SE pitch. #83950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/6.2
Are you sure you want to change the base?
Conversation
Explanation: This is a cherry pick of #82456, but with everything still non-public, along with a separate commit to make all the new functionality public, so that we can easily revert the latter and leave ourselves in a position where 6.2 is unchanged. |
@swift-ci Please test |
@swift-ci Please test macOS platform |
The macOS build is failing when trying to run |
@swift-ci Please test |
@swift-ci Please test Linux platform |
@swift-ci Please test |
@swift-ci Please test |
0cc63e5
to
c0f2768
Compare
swiftlang/swift-package-manager#9118 @swift-ci Please test |
We no longer attempt to convert timestamps from the passed-in `Clock` in order to allow any clock to work with any executor. Instead, executors that do not recognise a clock should call the `enqueue` function on that `Clock`, which lets the `Clock` itself decide how to proceed. Additionally, rename `SchedulableExecutor` to `SchedulingExecutor`.
This makes the custom global executor support and associated functionality public.
Without this, we may fail building Concurrency when enforcing strict availability. Addresses rdar://159473855
We need to tell SwiftPM's tests to run with `DYLD_LIBRARY_PATH` pointing to the new runtimes, otherwise they'll fail.
c0f2768
to
089b61d
Compare
swiftlang/swift-package-manager#9118 @swift-ci Please test |
There's now a new SwiftPM test failure, again I think unrelated to the code that has been changed. |
swiftlang/swift-package-manager#9118 @swift-ci Please test macOS platform |
1 similar comment
swiftlang/swift-package-manager#9118 @swift-ci Please test macOS platform |
(Trying macOS build again, but this time hopefully with the backtracer force-enabled.) |
swiftlang/swift-package-manager#9118 @swift-ci Please test macOS platform |
4ca86a5
to
089b61d
Compare
DO NOT MERGE.
swiftlang/swift-package-manager#9118 @swift-ci Please test macOS platform |
2 similar comments
swiftlang/swift-package-manager#9118 @swift-ci Please test macOS platform |
swiftlang/swift-package-manager#9118 @swift-ci Please test macOS platform |
We no longer attempt to convert timestamps from the passed-in
Clock
in order to allow any clock to work with any executor. Instead, executors that do not recognise a clock should call theenqueue
function on thatClock
, which lets theClock
itself decide how to proceed.Also, make all the new functionality public on the 6.2 branch (it's currently private).