Skip to content

Conversation

al45tair
Copy link
Contributor

We no longer attempt to convert timestamps from the passed-in Clock in order to allow any clock to work with any executor. Instead, executors that do not recognise a clock should call the enqueue function on that Clock, which lets the Clock itself decide how to proceed.

Also, make all the new functionality public on the 6.2 branch (it's currently private).

@al45tair al45tair requested a review from a team as a code owner August 27, 2025 16:39
@al45tair
Copy link
Contributor Author

al45tair commented Aug 27, 2025

Explanation: This is a cherry pick of #82456, but with everything still non-public, along with a separate commit to make all the new functionality public, so that we can easily revert the latter and leave ourselves in a position where 6.2 is unchanged.
Risk: Medium. The Clock API change is exercised by the test suite, but it is new code.
Original PR: #82456, #84018
Reviewed by: @ktoso
Resolves: rdar://154191435
Tests: The test suite exercises the Clock changes.

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

@swift-ci Please test macOS platform

@al45tair
Copy link
Contributor Author

The macOS build is failing when trying to run SwiftPMPackageTests.xctest, presumably because we're linking the system version of libswift_Concurrency.dylib rather than the just built version? The just built version definitely has the symbol, because it's in the ABI tests, and those have already passed.

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

@swift-ci Please test Linux platform

@al45tair
Copy link
Contributor Author

al45tair commented Sep 1, 2025

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented Sep 9, 2025

@swift-ci Please test

2 similar comments
@al45tair
Copy link
Contributor Author

al45tair commented Sep 9, 2025

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented Sep 9, 2025

@swift-ci Please test

@al45tair al45tair force-pushed the concurrency-updates-6.2 branch from 0cc63e5 to c0f2768 Compare September 10, 2025 10:18
@al45tair
Copy link
Contributor Author

al45tair and others added 4 commits September 10, 2025 11:41
We no longer attempt to convert timestamps from the passed-in `Clock`
in order to allow any clock to work with any executor.  Instead,
executors that do not recognise a clock should call the `enqueue`
function on that `Clock`, which lets the `Clock` itself decide how
to proceed.

Additionally, rename `SchedulableExecutor` to `SchedulingExecutor`.
This makes the custom global executor support and associated
functionality public.
Without this, we may fail building Concurrency when enforcing strict
availability.

Addresses rdar://159473855
We need to tell SwiftPM's tests to run with `DYLD_LIBRARY_PATH`
pointing to the new runtimes, otherwise they'll fail.
@al45tair al45tair force-pushed the concurrency-updates-6.2 branch from c0f2768 to 089b61d Compare September 10, 2025 10:42
@al45tair
Copy link
Contributor Author

@al45tair
Copy link
Contributor Author

There's now a new SwiftPM test failure, again I think unrelated to the code that has been changed.

@al45tair
Copy link
Contributor Author

swiftlang/swift-package-manager#9118

@swift-ci Please test macOS platform

1 similar comment
@al45tair
Copy link
Contributor Author

swiftlang/swift-package-manager#9118

@swift-ci Please test macOS platform

@al45tair
Copy link
Contributor Author

(Trying macOS build again, but this time hopefully with the backtracer force-enabled.)

@al45tair
Copy link
Contributor Author

swiftlang/swift-package-manager#9118

@swift-ci Please test macOS platform

@al45tair al45tair force-pushed the concurrency-updates-6.2 branch from 4ca86a5 to 089b61d Compare September 30, 2025 11:00
@al45tair
Copy link
Contributor Author

swiftlang/swift-package-manager#9118

@swift-ci Please test macOS platform

2 similar comments
@al45tair
Copy link
Contributor Author

al45tair commented Oct 1, 2025

swiftlang/swift-package-manager#9118

@swift-ci Please test macOS platform

@al45tair
Copy link
Contributor Author

al45tair commented Oct 8, 2025

swiftlang/swift-package-manager#9118

@swift-ci Please test macOS platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants